Mercurial > kallithea
changeset 5782:68764bdff7c9
status: refactor internal dict for mapping status string to description
Slightly better performance ... but more importantly: do it "the right way".
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Wed, 23 Mar 2016 18:27:45 +0100 |
| parents | 2824cb8bcc0e |
| children | b027fc1a0e85 |
| files | kallithea/lib/helpers.py kallithea/model/db.py |
| diffstat | 2 files changed, 3 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/lib/helpers.py Wed Mar 23 18:27:45 2016 +0100 +++ b/kallithea/lib/helpers.py Wed Mar 23 18:27:45 2016 +0100 @@ -1438,7 +1438,7 @@ def changeset_status_lbl(changeset_status): - return dict(ChangesetStatus.STATUSES).get(changeset_status) + return ChangesetStatus.get_status_lbl(changeset_status) def get_permission_name(key):
--- a/kallithea/model/db.py Wed Mar 23 18:27:45 2016 +0100 +++ b/kallithea/model/db.py Wed Mar 23 18:27:45 2016 +0100 @@ -2238,6 +2238,7 @@ (STATUS_REJECTED, _("Rejected")), (STATUS_UNDER_REVIEW, _("Under review")), ] + STATUSES_DICT = dict(STATUSES) changeset_status_id = Column(Integer(), unique=True, primary_key=True) repo_id = Column(Integer(), ForeignKey('repositories.repo_id'), nullable=False) @@ -2262,7 +2263,7 @@ @classmethod def get_status_lbl(cls, value): - return dict(cls.STATUSES).get(value) + return cls.STATUSES_DICT.get(value) @property def status_lbl(self):