changeset 5927:8049bb8502bd

pullrequests: update internal names after 'iteration' renaming
author Mads Kiilerich <madski@unity3d.com>
date Mon, 23 May 2016 18:02:33 +0200
parents 133686b535d1
children ecc2a13a308d
files kallithea/controllers/pullrequests.py
diffstat 1 files changed, 3 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/controllers/pullrequests.py	Mon May 23 18:02:33 2016 +0200
+++ b/kallithea/controllers/pullrequests.py	Mon May 23 18:02:33 2016 +0200
@@ -383,11 +383,10 @@
 
         raise HTTPFound(location=pull_request.url())
 
-    # TODO: rename to create_new_iteration or iterate ...
-    def create_update(self, old_pull_request, updaterev, title, description, reviewers_ids):
+    def create_new_iteration(self, old_pull_request, new_rev, title, description, reviewers_ids):
         org_repo = RepoModel()._get_repo(old_pull_request.org_repo.repo_name)
         org_ref_type, org_ref_name, org_rev = old_pull_request.org_ref.split(':')
-        new_org_rev = self._get_ref_rev(org_repo, 'rev', updaterev)
+        new_org_rev = self._get_ref_rev(org_repo, 'rev', new_rev)
 
         other_repo = RepoModel()._get_repo(old_pull_request.other_repo.repo_name)
         other_ref_type, other_ref_name, other_rev = old_pull_request.other_ref.split(':') # other_rev is ancestor
@@ -503,7 +502,7 @@
         reviewers_ids = [int(s) for s in _form['review_members']]
 
         if _form['updaterev']:
-            return self.create_update(pull_request,
+            return self.create_new_iteration(pull_request,
                                       _form['updaterev'],
                                       _form['pullrequest_title'],
                                       _form['pullrequest_desc'],