changeset 4080:b622e6849b67

pull requests: give slightly more useful error messages on failing form validation
author Mads Kiilerich <madski@unity3d.com>
date Wed, 12 Jun 2013 12:23:20 +0200
parents 7e897077bb40
children 089fb21d19d5
files rhodecode/controllers/pullrequests.py
diffstat 1 files changed, 2 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/rhodecode/controllers/pullrequests.py	Wed Jun 12 02:13:05 2013 +0200
+++ b/rhodecode/controllers/pullrequests.py	Wed Jun 12 12:23:20 2013 +0200
@@ -322,10 +322,10 @@
             elif errors.error_dict.get('pullrequest_title'):
                 msg = _('Pull request requires a title with min. 3 chars')
             else:
-                msg = _('Error creating pull request')
+                msg = _('Error creating pull request: %s') % errors.msg
 
             h.flash(msg, 'error')
-            return redirect(url('pullrequest_home', repo_name=repo_name))
+            return redirect(url('pullrequest_home', repo_name=repo_name)) ## would rather just go back to form ...
 
         org_repo = _form['org_repo']
         org_ref = _form['org_ref'] # will end with merge_rev but have symbolic name