Mercurial > kallithea

changeset 8433:c76eb3a60f6f stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
tests: actually test something useful in test_edit for gists (Issue #376) Even though there was a test for editing gists, it did not catch the basic loading problem reported in issue #376. In fact, the test just loaded the edit page, but since no user was actually logged in, it just loaded the login screen. As a result, no real gist editing code was tested at all. Instead, explicitly check the redirection to a login screen, then proceed with logging in and check that the edit page can be loaded. Additionally, don't rely on the magic gist id '1' but create an actual gist first. Note: the test does not yet really edit a gist.
author Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
date Sat, 23 May 2020 20:24:07 +0200
parents 3dfe049ec965
children ec4e69a60aae
files kallithea/tests/functional/test_admin_gists.py
diffstat 1 files changed, 8 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/tests/functional/test_admin_gists.py	Fri May 22 15:21:57 2020 +0200
+++ b/kallithea/tests/functional/test_admin_gists.py	Sat May 23 20:24:07 2020 +0200
@@ -168,4 +168,11 @@
         assert response.body == b'GIST BODY'
 
     def test_edit(self):
-        response = self.app.get(base.url('edit_gist', gist_id=1))
+        gist = _create_gist('gist-edit')
+        response = self.app.get(base.url('edit_gist', gist_id=gist.gist_access_id), status=302)
+        assert 'login' in response.location
+
+        self.log_user(base.TEST_USER_REGULAR_LOGIN, base.TEST_USER_REGULAR_PASS)
+        response = self.app.get(base.url('edit_gist', gist_id=gist.gist_access_id))
+
+        # FIXME actually test editing the gist