Mercurial > kallithea

changeset 3106:e26c11b68850 beta

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
remove reviewers button removes them without need of hitting save button.
author Marcin Kuzminski <marcin@python-works.com>
date Fri, 14 Dec 2012 03:31:44 +0100
parents 706b9f84ade3
children 172b11ecf245
files rhodecode/public/js/rhodecode.js rhodecode/templates/pullrequests/pullrequest_show.html
diffstat 2 files changed, 11 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/rhodecode/public/js/rhodecode.js	Fri Dec 14 03:24:30 2012 +0100
+++ b/rhodecode/public/js/rhodecode.js	Fri Dec 14 03:31:44 2012 +0100
@@ -712,6 +712,14 @@
 }
 
 var updateReviewers = function(reviewers_ids){
+	if (reviewers_ids === undefined){
+  	  var reviewers_ids = [];
+	  var ids = YUQ('#review_members input');
+	  for(var i=0; i<ids.length;i++){
+		  var id = ids[i].value
+		  reviewers_ids.push(id);
+	  }		
+	}
 	var url = AJAX_UPDATE_PULLREQUEST;
 	var postData = {'_method':'put',
 			        'reviewers_ids': reviewers_ids};
@@ -852,6 +860,7 @@
 	if (el.parentNode !== undefined){
 		el.parentNode.removeChild(el);
 	}
+	updateReviewers();
 }
 
 var fileBrowserListeners = function(current_url, node_list_url, url_base){
--- a/rhodecode/templates/pullrequests/pullrequest_show.html	Fri Dec 14 03:24:30 2012 +0100
+++ b/rhodecode/templates/pullrequests/pullrequest_show.html	Fri Dec 14 03:31:44 2012 +0100
@@ -198,16 +198,9 @@
           // inject comments into they proper positions
           var file_comments = YUQ('.inline-comment-placeholder');
           renderInlineComments(file_comments);
-
+          
           YUE.on(YUD.get('update_pull_request'),'click',function(e){
-
-        	  var reviewers_ids = [];
-        	  var ids = YUQ('#review_members input');
-        	  for(var i=0; i<ids.length;i++){
-        		  var id = ids[i].value
-        		  reviewers_ids.push(id);
-        	  }
-        	  updateReviewers(reviewers_ids);
+        	  updateReviewers();
           })
       })
     </script>