Mercurial > kallithea
changeset 3890:f5a1314886ec beta
replace list appends with list literals when possible
| author | Marcin Kuzminski <marcin@python-works.com> |
|---|---|
| date | Wed, 22 May 2013 03:17:42 +0200 |
| parents | b84c83b651de |
| children | aff5dd957f35 |
| files | rhodecode/controllers/feed.py rhodecode/lib/helpers.py rhodecode/lib/middleware/simplegit.py rhodecode/lib/vcs/backends/git/config.py rhodecode/lib/vcs/backends/git/repository.py |
| diffstat | 5 files changed, 7 insertions(+), 15 deletions(-) [+] |
line wrap: on
line diff
--- a/rhodecode/controllers/feed.py Wed May 22 03:15:44 2013 +0200 +++ b/rhodecode/controllers/feed.py Wed May 22 03:17:42 2013 +0200 @@ -87,9 +87,8 @@ return diff_processor, changes def __get_desc(self, cs): - desc_msg = [] - desc_msg.append((_('%s committed on %s') - % (h.person(cs.author), h.fmt_date(cs.date))) + '<br/>') + desc_msg = [(_('%s committed on %s') + % (h.person(cs.author), h.fmt_date(cs.date))) + '<br/>'] #branches, tags, bookmarks if cs.branch: desc_msg.append('branch: %s<br/>' % cs.branch)
--- a/rhodecode/lib/helpers.py Wed May 22 03:15:44 2013 +0200 +++ b/rhodecode/lib/helpers.py Wed May 22 03:17:42 2013 +0200 @@ -598,11 +598,9 @@ 'ref_name': _name }) revs.append(_rev) - cs_links = [] - cs_links.append(" " + ', '.join( + cs_links = [" " + ', '.join( [lnk(rev, repo_name) for rev in revs[:revs_limit]] - ) - ) + )] _op1, _name1 = _get_op(revs_ids[0]) _op2, _name2 = _get_op(revs_ids[-1])
--- a/rhodecode/lib/middleware/simplegit.py Wed May 22 03:15:44 2013 +0200 +++ b/rhodecode/lib/middleware/simplegit.py Wed May 22 03:17:42 2013 +0200 @@ -55,8 +55,7 @@ self.progress("counting objects: %d, done.\n" % len(objects_iter)) dulserver.write_pack_objects(dulserver.ProtocolFile(None, write), objects_iter) - messages = [] - messages.append('thank you for using rhodecode') + messages = ['thank you for using rhodecode'] for msg in messages: self.progress(msg + "\n")
--- a/rhodecode/lib/vcs/backends/git/config.py Wed May 22 03:15:44 2013 +0200 +++ b/rhodecode/lib/vcs/backends/git/config.py Wed May 22 03:17:42 2013 +0200 @@ -318,9 +318,7 @@ specified), the users' home directory and the system configuration. """ - paths = [] - paths.append(os.path.expanduser("~/.gitconfig")) - paths.append("/etc/gitconfig") + paths = [os.path.expanduser("~/.gitconfig"), "/etc/gitconfig"] backends = [] for path in paths: try:
--- a/rhodecode/lib/vcs/backends/git/repository.py Wed May 22 03:15:44 2013 +0200 +++ b/rhodecode/lib/vcs/backends/git/repository.py Wed May 22 03:17:42 2013 +0200 @@ -635,9 +635,7 @@ Tries to pull changes from external location. """ url = self._get_url(url) - cmd = ['pull'] - cmd.append("--ff-only") - cmd.append(url) + cmd = ['pull', "--ff-only", url] cmd = ' '.join(cmd) # If error occurs run_git_command raises RepositoryError already self.run_git_command(cmd)