Mercurial > kallithea

changeset 5793:fc8a5cbfa0da

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
compare: close Dulwich internals for Git repositories to avoid leaking open files Fix failing test_compare.py on Windows by explicitly closing internal object_store objects.
author domruf <dominikruf@gmail.com>
date Thu, 31 Mar 2016 20:53:23 +0200
parents 5a47ce11427c
children 9d645f4ede35
files kallithea/controllers/compare.py
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/controllers/compare.py	Mon Apr 04 23:34:30 2016 +0200
+++ b/kallithea/controllers/compare.py	Thu Mar 31 20:53:23 2016 +0200
@@ -130,6 +130,9 @@
                 else:
                     # no changesets from other repo, ancestor is the other_rev
                     ancestor = other_rev
+                # dulwich 0.9.9 doesn't have a Repo.close() so we have to mess with internals:
+                gitrepo.object_store.close()
+                gitrepo_remote.object_store.close()
 
             else:
                 so, se = org_repo.run_git_command(