Mercurial > kallithea

changeset 8258:fd92fe65a2ab

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
eslint: fix "is already defined"
author Mads Kiilerich <mads@kiilerich.com>
date Fri, 10 Jan 2020 00:34:22 +0100
parents d6efaa91e967
children 54d75eb32509
files kallithea/public/js/base.js kallithea/public/js/codemirror_loadmode.js kallithea/public/js/graph.js kallithea/templates/summary/statistics.html kallithea/templates/summary/summary.html
diffstat 5 files changed, 23 insertions(+), 24 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/public/js/base.js	Fri Jan 10 00:34:22 2020 +0100
+++ b/kallithea/public/js/base.js	Fri Jan 10 00:34:22 2020 +0100
@@ -409,14 +409,13 @@
 
 function ajaxPOST(url, postData, success, failure) {
     postData['_session_csrf_secret_token'] = _session_csrf_secret_token;
-    var postData = _toQueryString(postData);
     if(failure === undefined) {
         failure = function(jqXHR, textStatus) {
                 if (textStatus != "abort")
                     alert("Error posting to server: " + textStatus);
             };
     }
-    return $.ajax({url: url, data: postData, type: 'POST', headers: {'X-PARTIAL-XHR': '1'}, cache: false})
+    return $.ajax({url: url, data: _toQueryString(postData), type: 'POST', headers: {'X-PARTIAL-XHR': '1'}, cache: false})
         .done(success)
         .fail(failure);
 }
@@ -443,14 +442,14 @@
         $target.removeClass('follow').addClass('following');
         $target.prop('title', _TM['Stop following this repository']);
         if ($f_cnt.html()) {
-            var cnt = Number($f_cnt.html())+1;
+            const cnt = Number($f_cnt.html())+1;
             $f_cnt.html(cnt);
         }
     } else {
         $target.removeClass('following').addClass('follow');
         $target.prop('title', _TM['Start following this repository']);
         if ($f_cnt.html()) {
-            var cnt = Number($f_cnt.html())-1;
+            const cnt = Number($f_cnt.html())-1;
             $f_cnt.html(cnt);
         }
     }
@@ -551,7 +550,6 @@
         return _namespace[target];
     };
     return function (target, $nodes, display_element) {
-        var $nodes = $nodes;
         var $q_filter_field = $('#' + target);
         var F = namespace(target);
 
--- a/kallithea/public/js/codemirror_loadmode.js	Fri Jan 10 00:34:22 2020 +0100
+++ b/kallithea/public/js/codemirror_loadmode.js	Fri Jan 10 00:34:22 2020 +0100
@@ -10,13 +10,13 @@
     var deps = CodeMirror.modes[mode].dependencies;
     if (!deps) return cont();
     var missing = [];
-    for (var i = 0; i < deps.length; ++i) {
+    for (let i = 0; i < deps.length; ++i) {
       if (!CodeMirror.modes.hasOwnProperty(deps[i]))
         missing.push(deps[i]);
     }
     if (!missing.length) return cont();
     var split = splitCallback(cont, missing.length);
-    for (var i = 0; i < missing.length; ++i)
+    for (let i = 0; i < missing.length; ++i)
       CodeMirror.requireMode(missing[i], split);
   }
 
@@ -62,10 +62,11 @@
 
   CodeMirror.getFilenameAndExt = function(filename){
     var parts = filename.split('.');
+    var ext;
 
     if (parts.length > 1){
-        var ext = parts.pop();
-        var filename = parts.join("");
+        ext = parts.pop();
+        filename = parts.join("");
     }
     return {"filename": filename, "ext": ext};
   };
--- a/kallithea/public/js/graph.js	Fri Jan 10 00:34:22 2020 +0100
+++ b/kallithea/public/js/graph.js	Fri Jan 10 00:34:22 2020 +0100
@@ -82,7 +82,7 @@
 		}
 
 		var lineCount = 1;
-		for (var i=0;i<data.length;i++) {
+		for (let i=0;i<data.length;i++) {
 			var in_l = data[i][1];
 			for (var j in in_l) {
 				var m = in_l[j][0];
@@ -95,7 +95,7 @@
 		var box_size = Math.min(18, (canvasWidth - edge_pad * 2) / lineCount);
 		var base_x = canvasWidth - edge_pad;
 
-		for (var i=0; i < data.length; ++i) {
+		for (let i=0; i < data.length; ++i) {
 			var row = document.getElementById(row_id_prefix+idx);
 			if (row == null) {
 				console.log("error: row "+row_id_prefix+idx+" not found");
@@ -120,7 +120,7 @@
 			var rowY = Math.floor(row.offsetTop + firstincell.offsetTop + firstincell.offsetHeight/2);
 			var nextY = Math.floor((next == null) ? rowY + row.offsetHeight/2 : next.offsetTop + nextFirstincell.offsetTop + nextFirstincell.offsetHeight/2);
 
-			for (var j in in_l) {
+			for (let j in in_l) {
 				const line = in_l[j];
 				const start = line[0];
 				const end = line[1];
@@ -146,7 +146,7 @@
 				}
 
 				if (dead_end) {
-					var gradient = this.ctx.createLinearGradient(x,rowY,x,nextY);
+					let gradient = this.ctx.createLinearGradient(x,rowY,x,nextY);
 					gradient.addColorStop(0,this.calcColor(color, 0.0, 0.65));
 					gradient.addColorStop(1,this.calcColor(color, 1.0, 0.0));
 					this.ctx.strokeStyle = gradient;
@@ -157,7 +157,7 @@
 				// the merged color
 				else if (color != node[1] && start == node[0])
 				{
-					var gradient = this.ctx.createLinearGradient(x,rowY,x,nextY);
+					let gradient = this.ctx.createLinearGradient(x,rowY,x,nextY);
 					gradient.addColorStop(0,this.calcColor(node[1], 0.0, 0.65));
 					gradient.addColorStop(1,this.calcColor(color, 0.0, 0.65));
 					this.ctx.strokeStyle = gradient;
--- a/kallithea/templates/summary/statistics.html	Fri Jan 10 00:34:22 2020 +0100
+++ b/kallithea/templates/summary/statistics.html	Fri Jan 10 00:34:22 2020 +0100
@@ -57,10 +57,10 @@
 var tbl = document.createElement('table');
 tbl.setAttribute('class','trending_language_tbl');
 var cnt = 0;
-for (var i=0;i<data.length;i++){
+for (let i=0;i<data.length;i++){
     total+= data[i][1].count;
 }
-for (var i=0;i<data.length;i++){
+for (let i=0;i<data.length;i++){
     cnt += 1;
 
     var hide = cnt>2;
@@ -136,13 +136,13 @@
             "to":to
         }
     };
-    for(var key in dataset){
-      var data = dataset[key].data;
+    for(let key in dataset){
+      let data = dataset[key].data;
       for(var d in data){
         data[d].time *= 1000;
       }
     }
-    for(var key in overview_dataset){
+    for(let key in overview_dataset){
       overview_dataset[key][0] *= 1000;
     }
     var choiceContainer = $("#legend_choices")[0];
@@ -377,7 +377,7 @@
             if (previousPoint != item.datapoint) {
                 previousPoint = item.datapoint;
 
-                var tooltip = $("#tooltip")[0];
+                let tooltip = $("#tooltip")[0];
                 if(tooltip) {
                       tooltip.parentNode.removeChild(tooltip);
                 }
@@ -414,7 +414,7 @@
             }
         }
         else {
-              var tooltip = $("#tooltip")[0];
+              let tooltip = $("#tooltip")[0];
 
               if(tooltip) {
                     tooltip.parentNode.removeChild(tooltip);
@@ -427,7 +427,7 @@
      * MAIN EXECUTION
      */
 
-    var data = getDataAccordingToRanges(initial_ranges);
+    let data = getDataAccordingToRanges(initial_ranges);
     generateCheckboxes(data);
 
     //main plot
--- a/kallithea/templates/summary/summary.html	Fri Jan 10 00:34:22 2020 +0100
+++ b/kallithea/templates/summary/summary.html	Fri Jan 10 00:34:22 2020 +0100
@@ -341,10 +341,10 @@
     var tbl = document.createElement('table');
     tbl.setAttribute('class','table');
     var cnt = 0;
-    for (var i=0;i<data.length;i++){
+    for (let i=0;i<data.length;i++){
         total+= data[i][1].count;
     }
-    for (var i=0;i<data.length;i++){
+    for (let i=0;i<data.length;i++){
         cnt += 1;
 
         var hide = cnt>2;