changeset 8990:1aa109aea143 stable

repo group: stop giving explicit admin permission to owner on create The repo owner will always get admin permissions when computing permissions, so there is no need to assign these permissions explicitly. Note: Permissions that has been added in the past are redundant but will be kept.
author Mads Kiilerich <mads@kiilerich.com>
date Sun, 07 May 2023 18:20:50 +0200
parents e27ff6a90076
children 2e1059de6751
files kallithea/model/repo_group.py
diffstat 1 files changed, 0 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/model/repo_group.py	Sun May 07 18:19:38 2023 +0200
+++ b/kallithea/model/repo_group.py	Sun May 07 18:20:50 2023 +0200
@@ -148,12 +148,6 @@
 
             meta.Session().add(new_repo_group)
 
-            # create an ADMIN permission for owner except if we're super admin,
-            # later owner should go into the owner field of groups
-            if not owner.is_admin:
-                self.grant_user_permission(repo_group=new_repo_group,
-                                           user=owner, perm='group.admin')
-
             if parent_group and copy_permissions:
                 # copy permissions from parent
                 user_perms = db.UserRepoGroupToPerm.query() \