Mercurial > kallithea
changeset 8989:e27ff6a90076 stable
auth: always consider the repo group owner an admin when computing it's permissions
When computing repo group permissions in repository_group_permissions(), always
give admin permissions to the group owner.
That is similar to how repository_permissions() gives admin permissions to the
repo owner.
The extra computation shouldn't cause any extra database hits or make the
computation more complex or expensive, so that should be fine for stable.
Note: This will leave behind some (automaticly added) explicit permissions. I
consider this a very minor glitch, not worth addressing.
| author | Mads Kiilerich <mads@kiilerich.com> |
|---|---|
| date | Sun, 07 May 2023 18:19:38 +0200 |
| parents | 511b20a6475d |
| children | 1aa109aea143 |
| files | kallithea/lib/auth.py |
| diffstat | 1 files changed, 4 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/lib/auth.py Thu Mar 30 03:22:35 2023 +0200 +++ b/kallithea/lib/auth.py Sun May 07 18:19:38 2023 +0200 @@ -262,7 +262,10 @@ # on given group for perm in default_repo_groups_perms: rg_k = perm.group.group_name - p = perm.permission.permission_name + if perm.group.owner_id == self.user_id: + p = 'group.admin' + else: + p = perm.permission.permission_name repository_group_permissions[rg_k] = p # user group for repo groups permissions