Mercurial > kallithea
changeset 5423:42ce8e54bae5
pullrequests: remove reviewer list during PR creation
There is not much use for it before the actual diff is shown ... and removing
it also removes a bit of duplicated code that otherwise should be maintained in
two places.
| author | Søren Løvborg <sorenl@unity3d.com> |
|---|---|
| date | Thu, 13 Aug 2015 21:52:18 +0200 |
| parents | 33249f840ecd |
| children | b361974171ea |
| files | kallithea/controllers/pullrequests.py kallithea/templates/pullrequests/pullrequest.html |
| diffstat | 2 files changed, 0 insertions(+), 29 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/controllers/pullrequests.py Thu Aug 20 17:29:55 2015 +0200 +++ b/kallithea/controllers/pullrequests.py Thu Aug 13 21:52:18 2015 +0200 @@ -67,12 +67,6 @@ class PullrequestsController(BaseRepoController): - def __before__(self): - super(PullrequestsController, self).__before__() - repo_model = RepoModel() - c.users_array = repo_model.get_users_js() - c.user_groups_array = repo_model.get_user_groups_js() - def _get_repo_refs(self, repo, rev=None, branch=None, branch_rev=None): """return a structure with repo's interesting changesets, suitable for the selectors in pullrequest.html
--- a/kallithea/templates/pullrequests/pullrequest.html Thu Aug 20 17:29:55 2015 +0200 +++ b/kallithea/templates/pullrequests/pullrequest.html Thu Aug 13 21:52:18 2015 +0200 @@ -92,25 +92,6 @@ </div> - ## Reviewers - <div style="float:left; border-left:1px dashed #eee"> - <div class="pr-details-title">${_('Pull Request Reviewers')}</div> - <div id="reviewers" style="padding:0px 0px 0px 15px"> - ## members goes here ! - <div> - <ul id="review_members" class="group_members"> - </ul> - </div> - - <div class='ac'> - <div class="reviewer_ac"> - ${h.text('user', class_='yui-ac-input',placeholder=_('Type name of reviewer to add'))} - <div id="reviewers_container"></div> - </div> - </div> - </div> - </div> - <div style="clear:both;padding: 0 0 30px 0;"></div> <h4>${_('Changesets')}</h4> @@ -128,10 +109,6 @@ <script type="text/javascript" src="${h.url('/js/graph.js', ver=c.kallithea_version)}"></script> <script type="text/javascript"> - var _USERS_AC_DATA = ${c.users_array|n}; - var _GROUPS_AC_DATA = ${c.user_groups_array|n}; - PullRequestAutoComplete($('#user'), $('#reviewers_container'), _USERS_AC_DATA); - pyroutes.register('pullrequest_repo_info', "${url('pullrequest_repo_info',repo_name='%(repo_name)s')}", ['repo_name']); var pendingajax = undefined;