Mercurial > kallithea

changeset 5384:99d29f43bdd1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
comments: bind comment-bubble click handler to table and use sub selector Avoid jQuery looping over all lines and binding comment-bubble click handler to every line on page load. Avoids 'Maximum call stack size exceeded' when loading a huge diff in Chrome.
author Mads Kiilerich <madski@unity3d.com>
date Tue, 11 Aug 2015 12:39:07 +0200
parents 144878118c95
children b8734b428786
files kallithea/templates/changeset/changeset.html kallithea/templates/pullrequests/pullrequest_show.html
diffstat 2 files changed, 2 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/templates/changeset/changeset.html	Tue Aug 11 12:39:07 2015 +0200
+++ b/kallithea/templates/changeset/changeset.html	Tue Aug 11 12:39:07 2015 +0200
@@ -224,7 +224,7 @@
               }
           });
 
-          $('.add-bubble').click(function(e){
+          $('.code-difftable').on('click', '.add-bubble', function(e){
               show_comment_form($(this));
           });
 
--- a/kallithea/templates/pullrequests/pullrequest_show.html	Tue Aug 11 12:39:07 2015 +0200
+++ b/kallithea/templates/pullrequests/pullrequest_show.html	Tue Aug 11 12:39:07 2015 +0200
@@ -376,7 +376,7 @@
       $(document).ready(function(){
           PullRequestAutoComplete('user', 'reviewers_container', _USERS_AC_DATA);
 
-          $('.add-bubble').click(function(e){
+          $('.code-difftable').on('click', '.add-bubble', function(e){
               show_comment_form($(this));
           });