changeset 5732:ba3bdd16ca2d

db: make return type for get_comments consistent - don't return a list for the empty case
author Mads Kiilerich <madski@unity3d.com>
date Tue, 01 Mar 2016 00:16:38 +0100
parents bc6178c3b67b
children d21305f7f166
files kallithea/model/db.py
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/model/db.py	Wed Feb 10 12:01:22 2016 +0000
+++ b/kallithea/model/db.py	Tue Mar 01 00:16:38 2016 +0100
@@ -1388,7 +1388,7 @@
             .filter(ChangesetComment.repo == self)
         if revisions is not None:
             if not revisions:
-                return [] # don't use sql 'in' on empty set
+                return {} # don't use sql 'in' on empty set
             cmts = cmts.filter(ChangesetComment.revision.in_(revisions))
         grouped = collections.defaultdict(list)
         for cmt in cmts.all():